Skip to content

Delete random_normal_distribution_quicksort.py #9181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Delete random_normal_distribution_quicksort.py #9181

wants to merge 3 commits into from

Conversation

tianyizheng02
Copy link
Contributor

Describe your change:

Fixes #9124

As I had just discovered in #9178 and #9124, both random_pivot_quick_sort.py and random_normal_distribution_quicksort.py are duplicates of quick_sort.py because they all implement quick sort with a random pivot.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?
  • Delete a duplicate algorithm

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

github-actions and others added 3 commits October 1, 2023 04:41
updating DIRECTORY.md
ceb4680
@tianyizheng02
Delete sorts/random_normal_distribution_quicksort.py
505260c 
Deleting this file because it's a duplicate of quick_sort.py. Both files implement quick sort with a random pivot, and the only difference with this implementation is that the array elements themselves are normally distributed.
updating DIRECTORY.md
1041435
@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Oct 1, 2023
@tianyizheng02
Copy link
Contributor Author

Failing test in this file again...

=========================== short test summary info ============================
FAILED web_programming/fetch_anime_and_play.py::web_programming.fetch_anime_and_play.get_anime_episode
=========== 1 failed, 1500 passed, 28 warnings in 102.05s (0:01:42) ============

@tianyizheng02
Copy link
Contributor Author

Closing in favor of #9182

@tianyizheng02 tianyizheng02 deleted the delete-rand-norm-dist-quicksort branch October 1, 2023 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files tests are failing Do not merge until tests pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sorts/random_normal_distribution_quicksort.py has no tests
1 participant
@tianyizheng02